Email fix #159
Merged
Email fix #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ss` program is now the official replacement for `netstat` which is deprecated in most Linux distributions. Also replace the messy sed rules which do not work on all versions with a clean command-line that just displays the key information that does **not** change on every command run (e.g. PID) resulting in false positives.
Tell `df` not to report on virtual filesystems such as `squashfs` (used by `snapd` and always at 100%), `tmpfs` (memory-only) and `devtmpfs` (used by `udev`)
Without this flag the agent will not accept any system check commands (`command` and `full_command`) configured in the Wazuh Manager settings to cascade down to agents.
There's no need for a complicated if..then condition here since the value is expected to be yes/no only
|
Hello @kravietz , Thank you for your amazing work, your contributions are very valuable for us. Could you please write here a description of your PR's functionality? It'd be needed in order to test it properly. Cheers |
kravietz
commented
Mar 27, 2019
There was a problem hiding this comment.
- The
dfchange suppresses changes in disk space display on pseudo-devices which are always 100% full such as squashfs or which are dynamically allocated such as tmpfs - Netstat change uses
ssinstead ofnetstatwhich is now deprecated and simplifies the command significantly to suppress information that changes frequently (buffer sizes, PID etc) - logcollector change allows the agents to receive commands for execution from master (such as
netstat) - Email notification change simplifies the template to simply embed the variable value
|
Thanks @kravietz ! We will review it ASAP. Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.